tests-via-crave: limit paths#4449
Merged
Merged
Conversation
janhoy
reviewed
May 19, 2026
| - '*' | ||
| paths: | ||
| - 'solr/**/src/**' | ||
| - 'gradle/libs.versions.toml' |
Contributor
There was a problem hiding this comment.
Shuold changes to the broader gradle build files also trigger a full test
janhoy
approved these changes
May 19, 2026
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
LGTM. Not sure about gradle/** - but the precommit tests are probably enough to catch bugs that might be introduced in the build?
Contributor
Author
|
It's of course possible to imagine changes that wouldn't trigger this workflow that could cause a test to fail (e.g. certain gradle/build changes relating to tests) but I think this is fine & simple. We can always change it later if we grow dissatisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't want to run Crave for PRs that merely touch the changelog or for some other things.