SOLR-18252: Fix flaky test by avoiding race conditions.#4462
Merged
Conversation
Contributor
|
I have recently used TimeOut, and I was wondering if there are any strong patterns in how we use, because I thoguht I had seen a streamlined pattern then how hyou used it. I asked Claude for some help, and it reminde me we have done a couple of lamda uses with timeout: Not sure if that is useful at all to you, but I appreciate your working on the flaky test! |
Contributor
Author
|
@epugh looks nice, good to know. But in this case the lambda is relatively large so I think it would be less readable than this explicit loop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a flaky test. ArrayList has been replaced with a BlockingQueue, plus used a better approach to consuming the records being collected in the queue.