SOLR-17855: restore dropwizard-metrics, runtimeOnly#4468
Merged
Conversation
github-actions
Bot
added
documentation
dsmiley
commented
May 25, 2026
| decompose-decompose = { module = "com.arkivanov.decompose:decompose", version.ref = "decompose" } | ||
| decompose-extensions-compose = { module = "com.arkivanov.decompose:extensions-compose", version.ref = "decompose" } | ||
| dropwizard-metrics-core = { module = "io.dropwizard.metrics:metrics-core", version.ref = "dropwizard-metrics" } | ||
| dropwizard-metrics-jetty12-ee10 = { module = "io.dropwizard.metrics:metrics-jetty12-ee10", version.ref = "dropwizard-metrics" } |
Contributor
Author
There was a problem hiding this comment.
woops... a mistake; I will remove this line
Contributor
Author
|
I'm going to merge this tonight if I don't get a review sooner. Our BATS integration tests have been failing and this fixes it. |
janhoy
approved these changes
May 26, 2026
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
Looks good, perhaps a rephrase of changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17855
Needed at runtime when we embed a ZK server.