SOLR-15836: Address counterintuitive behavior of JSON "terms" subfacet refinement#448
Closed
magibney wants to merge 47 commits intoapache:mainfrom
Closed
SOLR-15836: Address counterintuitive behavior of JSON "terms" subfacet refinement#448magibney wants to merge 47 commits intoapache:mainfrom
magibney wants to merge 47 commits intoapache:mainfrom
Conversation
Contributor
Author
|
The initial test didn't actually work/demo what it was supposed to. Not sure how I overlooked that. 184c59b gets the test working properly (failing, AwaitsFix). |
this includes a fix to consider that any facet with a processEmpty descendant can produce from empty.
we will probably have to account for this when fleshing out
`iterative` refinement in practice, so:
gradlew :solr:core:test --tests "org.apache.solr.search.facet.TestCloudJSONFacetSKGEquiv.testRandom"
-Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=6017F91BDD748C67
-Ptests.file.encoding=ISO-8859-1
This includes a bugfix clearing sortedBuckets between subsequent iterations of `iterative` refinement
…rue` for the `testChildPhase1Exclutions` case
…rgeWithOverrefine)
… an intuitively "correct" way
including additional detail and description of refinement generally
…to all facet types
|
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
|
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: SOLR-15836
Initial commit simply adds a test demonsrating counterintuitive subfacet refinement.