Skip to content

SOLR-15838: Update Solr to use released Lucene 9.0.0#449

Merged
uschindler merged 4 commits intoapache:mainfrom
uschindler:jira/SOLR-15838
Dec 8, 2021
Merged

SOLR-15838: Update Solr to use released Lucene 9.0.0#449
uschindler merged 4 commits intoapache:mainfrom
uschindler:jira/SOLR-15838

Conversation

@uschindler
Copy link
Contributor

@uschindler uschindler requested a review from dweiss December 7, 2021 16:26
@uschindler
Copy link
Contributor Author

I left the nightlies repository code commented out, so we can use the mechanism again in the future.

@uschindler uschindler self-assigned this Dec 7, 2021
@uschindler uschindler requested a review from jpountz December 7, 2021 16:27
@uschindler
Copy link
Contributor Author

Adding @jpountz as reviewer, because he did the Lucene 9.0 release to Maven central.

To me it looks like all Maven artifacts resolve correctly from Maven central.

@uschindler
Copy link
Contributor Author

I am not 100% sure, but it looks like we do not add checksums and Licenses for Lucene's JAR files. IMHO we should now also add them to make sure all files are sane. Also Lucene is now a third party project, so we should have License, too.

@uschindler
Copy link
Contributor Author

In the PR I added checksums and License/Notice.

Basically the NOTICE.txt file in the root folder of Lucene seems obsolete. I did not touch, it may be a separate issue.

@uschindler
Copy link
Contributor Author

Basically the NOTICE.txt file in the root folder of Lucene seems obsolete. I did not touch, it may be a separate issue.

not fully obsolete, but all third party text can be removed.

@uschindler uschindler requested a review from janhoy December 7, 2021 17:07
Copy link
Contributor

@madrob madrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nearly identical to the set of changes I was making on my end before I realized that you were working on this as well.

@uschindler
Copy link
Contributor Author

I also did some quick checks, Admin UI shows correct versions:

image

Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Related question - Solr still uses Lucene's Version class several places. It's probably right when determining index compatibility, analysis components etc, but other places such as in Package Manager and outputing Solr's current version on startup and SolrCLI's version, it will be wrong. Do we have a JIRA already to introduce a SolrVersion class and use it where it makes sense?

@uschindler
Copy link
Contributor Author

Related question - Solr still uses Lucene's Version class several places. It's probably right when determining index compatibility, analysis components etc, but other places such as in Package Manager and outputing Solr's current version on startup and SolrCLI's version, it will be wrong. Do we have a JIRA already to introduce a SolrVersion class and use it where it makes sense?

I think this should be done! Especially the Package#getImplementationVersion() no longer works with module system, so Solr should at some point use the same code as Lucene's Version class to get implementation version from its JAR file (in case module system is present): apache/lucene#473

I will merge this now, this should be separate issue.

@uschindler uschindler merged commit aa8c976 into apache:main Dec 8, 2021
@uschindler uschindler deleted the jira/SOLR-15838 branch December 8, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants