SOLR-15838: Update Solr to use released Lucene 9.0.0#449
SOLR-15838: Update Solr to use released Lucene 9.0.0#449uschindler merged 4 commits intoapache:mainfrom
Conversation
|
I left the nightlies repository code commented out, so we can use the mechanism again in the future. |
|
Adding @jpountz as reviewer, because he did the Lucene 9.0 release to Maven central. To me it looks like all Maven artifacts resolve correctly from Maven central. |
|
I am not 100% sure, but it looks like we do not add checksums and Licenses for Lucene's JAR files. IMHO we should now also add them to make sure all files are sane. Also Lucene is now a third party project, so we should have License, too. |
|
In the PR I added checksums and License/Notice. Basically the NOTICE.txt file in the root folder of Lucene seems obsolete. I did not touch, it may be a separate issue. |
not fully obsolete, but all third party text can be removed. |
madrob
left a comment
There was a problem hiding this comment.
This is nearly identical to the set of changes I was making on my end before I realized that you were working on this as well.
janhoy
left a comment
There was a problem hiding this comment.
LGTM.
Related question - Solr still uses Lucene's Version class several places. It's probably right when determining index compatibility, analysis components etc, but other places such as in Package Manager and outputing Solr's current version on startup and SolrCLI's version, it will be wrong. Do we have a JIRA already to introduce a SolrVersion class and use it where it makes sense?
I think this should be done! Especially the I will merge this now, this should be separate issue. |

See https://issues.apache.org/jira/browse/SOLR-15838