Skip to content

build/tests: tests.ssl=false now works#4500

Open
dsmiley wants to merge 2 commits into
apache:mainfrom
dsmiley:buildImproveSslToggle
Open

build/tests: tests.ssl=false now works#4500
dsmiley wants to merge 2 commits into
apache:mainfrom
dsmiley:buildImproveSslToggle

Conversation

@dsmiley
Copy link
Copy Markdown
Contributor

@dsmiley dsmiley commented Jun 5, 2026

... but honor @RandomizeSSL(1.0)

but honor @RandomizeSSL(0.0)
@hossman
Copy link
Copy Markdown
Member

hossman commented Jun 5, 2026

+1

@hossman
Copy link
Copy Markdown
Member

hossman commented Jun 5, 2026

I don't know if this is a good idea or a terrible idea, but it just occurred to me -- should we do something like...

// a test can configure @RandomizeSSL(0.0) or with 1.0, and we must honor that.
final String sslProp = System.getProperty("tests.ssl");
if ("true".equals(sslProp)) {
  assumeFalse("tests.ssl=true but test does not support SSL", ssl == 0.0)
  return new SSLTestConfig(true, useClientAuth);
} else if ("false".equals(sslProp)) {
  assumeFalse("tests.ssl=false but test requires SSL", ssl == 1.0)
  return new SSLTestConfig(false, false);
}

?

@github-actions github-actions Bot added the tests label Jun 6, 2026
@dsmiley
Copy link
Copy Markdown
Contributor Author

dsmiley commented Jun 6, 2026

I took you idea and tested it both ways. One test needed better recovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants