Skip to content

SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?)#452

Merged
uschindler merged 1 commit intoapache:mainfrom
uschindler:jira/SOLR-15839
Dec 8, 2021
Merged

SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?)#452
uschindler merged 1 commit intoapache:mainfrom
uschindler:jira/SOLR-15839

Conversation

@uschindler
Copy link
Contributor

@uschindler uschindler changed the title SOLR-15839: Don't mocj Sort class (why the hell was this needed?) SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?) Dec 8, 2021
@uschindler
Copy link
Contributor Author

This is a fishy, stinky, and SNEAKY thing to mock!

@uschindler uschindler self-assigned this Dec 8, 2021
@uschindler
Copy link
Contributor Author

Sneaky test passes:

gradlew :solr:core:test --tests QueryComponentPartialResultsTest
To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.2/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build

> Task :randomizationInfo
Running tests with randomization seed: tests.seed=AE79BECFA5AFD6B4

> Task :solr:core:test
:solr:core:test (SUCCESS): 4 test(s)
The slowest suites (exceeding 1s) during this run:
   2.95s QueryComponentPartialResultsTest (:solr:core)

@uschindler uschindler added the bug Something isn't working label Dec 8, 2021
@uschindler uschindler merged commit 84a542c into apache:main Dec 8, 2021
@uschindler uschindler deleted the jira/SOLR-15839 branch December 8, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant