Overhaul Apache RAT#4569
Open
dsmiley wants to merge 1 commit into
Open
Conversation
* Upgrade from 0.15 to 0.18 * Use a config file * Remove custom license patterns that match nothing anymore * Ensure works even without a git working tree (e.g. smoketester source release) * Add a canary to assert that header detection is actually working each run * Synchronize RatTask executions to avoid shared Ant task state issues under parallel Gradle execution * Consolidate all exclude patterns into a single include-everything-then-exclude approach
dsmiley
commented
Jun 29, 2026
dsmiley
left a comment
dsmiley
left a comment
Contributor
Author
There was a problem hiding this comment.
I chickened out and didn't pull out jgit... but was tempted.
Contributor
Author
There was a problem hiding this comment.
Instead of tying this to RAT, the needs are too simple/basic to warrant that coupling.
| exclude "**/.*" // e.g. .gradle, .github, .junie, .gitignore, etc. | ||
| } else { | ||
| // Source release (no git): scan everything, exclude generated/ignored paths manually. | ||
| include "**" |
Contributor
Author
There was a problem hiding this comment.
key change here, esp. for the source release validation (smoketester). Include all by default.
| // TODO: SOLR-15601: Some of these should carry the license, perhaps? | ||
| exclude "**/*.html" | ||
| exclude subprojects.collect { | ||
| projectDir.toPath().relativize(it.projectDir.toPath()).toString().replace('\\', '/') |
Contributor
Author
There was a problem hiding this comment.
was overly simple before, thus would exclude any "core" dir anywhere for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: requires the PR that excludes dev-docs and dot-files from the source release, in order for RAT to pass on smoketest release