Skip to content

Added support in solrj client to add query fields/params through java 8 consumer#463

Closed
venkatrockz wants to merge 2 commits intoapache:mainfrom
venkatrockz:enhance-slor-query
Closed

Added support in solrj client to add query fields/params through java 8 consumer#463
venkatrockz wants to merge 2 commits intoapache:mainfrom
venkatrockz:enhance-slor-query

Conversation

@venkatrockz
Copy link
Copy Markdown

@venkatrockz venkatrockz commented Dec 21, 2021

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

Added support in solrj client to add query fields/params through java 8 consumer. I have added new method in solr query class which will take solr query consumer as parameter and return the solr query in order to make it easy for chaining.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@janhoy
Copy link
Copy Markdown
Contributor

janhoy commented Jan 17, 2022

Please create a JIRA and fill in the PR template. Also, you have to explain the feature you are proposing much more in detail. Give examples of what is difficult to achieve today, then explain what a Consumer is and how to use it and why you think it justifies expanding the API. Then there may be some discussion in JIRA or here in the PR.

If there is agreement that this is useful, you'd need to also add CHANGES.txt entry and Reference Guide documentation (if applicable)

@janhoy
Copy link
Copy Markdown
Contributor

janhoy commented Mar 10, 2022

Any followup on this?

@venkatrockz venkatrockz closed this by deleting the head repository Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants