Skip to content

Comments

New dev-tools/scripts/cherrypick.sh#514

Merged
janhoy merged 10 commits intoapache:mainfrom
janhoy:cherrypick_tool
Jan 13, 2022
Merged

New dev-tools/scripts/cherrypick.sh#514
janhoy merged 10 commits intoapache:mainfrom
janhoy:cherrypick_tool

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Jan 11, 2022

Script that may assist in boring backporting trivial features - especially where you don't expect any merge conflicts. See usage in script.

Tested just a few times, but I hope it will be useful when having to backport many small fixes twice between branches that are almost identical. Take it for a spin..

Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so good in verifying this, because I find she'll scripts are a pain.

I am fine with a script like this, can't verify it completely. 🤔 At least I found no filename-with-spaces issue. 🤓

# See the License for the specific language governing permissions and
# limitations under the License.

# Forked and adapted from https://github.com/factorial-io/cherrypicker - MIT license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the legal implications of this... I think it's fine but will try to find precedent from legal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIT license is more liberal than ours. We might want to add the (c) notice to our main LICENSE.txt perhaps.

@janhoy janhoy merged commit ed74ee5 into apache:main Jan 13, 2022
@janhoy janhoy deleted the cherrypick_tool branch January 13, 2022 01:18
janhoy added a commit that referenced this pull request Jan 13, 2022
janhoy added a commit that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants