SOLR-15922 SolrExporterIntegrationTest fails on Java 17#547
Merged
janhoy merged 2 commits intoapache:mainfrom Jan 20, 2022
Merged
SOLR-15922 SolrExporterIntegrationTest fails on Java 17#547janhoy merged 2 commits intoapache:mainfrom
janhoy merged 2 commits intoapache:mainfrom
Conversation
madrob
approved these changes
Jan 20, 2022
Contributor
madrob
left a comment
madrob
left a comment
There was a problem hiding this comment.
LGTM, one minor comment, did not run tests on Java 17 yet. If you have run them feel free to merge
solr/contrib/prometheus-exporter/src/test/org/apache/solr/prometheus/utils/Helpers.java
Outdated
Show resolved
Hide resolved
uschindler
approved these changes
Jan 20, 2022
Contributor
uschindler
left a comment
uschindler
left a comment
There was a problem hiding this comment.
Looks fine to. The line parsing is now isolated and meaningful format errors coming from new method. The main issue was that the error message was not really meaningful.
janhoy
added a commit
that referenced
this pull request
Jan 20, 2022
(cherry picked from commit be61551)
janhoy
added a commit
that referenced
this pull request
Jan 20, 2022
(cherry picked from commit be61551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15922