SOLR-16048: Examine Tika dependencies that brought in javax classes#693
SOLR-16048: Examine Tika dependencies that brought in javax classes#693risdenk merged 1 commit intoapache:mainfrom
Conversation
janhoy
left a comment
There was a problem hiding this comment.
There is still 1 constraint for jakarta.annotation-api and we still have it in solr/licenses. But we don't ship the jar. gradle why shows this on my machine, probably some test dependency, which (still) requires a license entry.
> Task :why
jakarta.annotation:jakarta.annotation-api:1.3.5
org.springframework.boot:spring-boot-starter -> 1.3.5
|
@janhoy so I went to remove |
|
Yeah I know I added a lot of jakarta and jaxb dependencies with the s3-repository. Was definitely needed at the time. |
|
Agree. Would definitely be good to have this logic and whitelist in grade for early detection, but we can do that later. |
Yes, I think we should add this as a gradle task. Having it only in smoke tester was the only possibility back at that time. Let's open a separate issue. This would also be useful for Lucene regarding accidentally importing servlet-api or others. |
* jakarta.annotation-api - this should be allowed so exclusion in smokeTestRelease * jakarta.activation - this should be allowed so exclusion in smokeTestRelease * jakarta.xml.bind-api - this should be allowed so exclusion in smokeTestRelease * unit-api - this should be allowed so exclusion in smokeTestRelease * removed jersey and xml-api exclusion since they aren't dependencies anymore
https://issues.apache.org/jira/browse/SOLR-16048
anymore