SOLR-14920: Spotless formatting for test-framework#704
Merged
risdenk merged 4 commits intoapache:mainfrom Feb 25, 2022
Merged
Conversation
risdenk
commented
Feb 24, 2022
Contributor
Author
risdenk
left a comment
risdenk
left a comment
There was a problem hiding this comment.
Went through all the files quickly and highlighted a few things to address
solr/test-framework/src/test/org/apache/solr/util/TestSSLTestConfig.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/solr/cloud/api/collections/AbstractCollectionsAPIDistributedZkTestBase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/AbstractRecoveryZkTestBase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/AbstractMoveReplicaTestBase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/AbstractMoveReplicaTestBase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/test/org/apache/solr/TestLogLevelAnnotations.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/test/org/apache/solr/TestLogLevelAnnotations.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
Outdated
Show resolved
Hide resolved
risdenk
requested review from
ErickErickson,
dsmiley,
gerlowskija,
hossman,
janhoy and
madrob
dsmiley
reviewed
Feb 24, 2022
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
mostly just some reflow issues. I wonder if spotless will reflow /* foo bar */ style comments.
solr/test-framework/src/java/org/apache/solr/SolrTestCaseHS.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/SolrTestCaseHS.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/util/LogLevel.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/util/LogListener.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/test/org/apache/solr/cloud/MiniSolrCloudClusterTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
dsmiley
approved these changes
Feb 25, 2022
risdenk
added a commit
that referenced
this pull request
Feb 25, 2022
risdenk
added a commit
that referenced
this pull request
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14920