SOLR-16092 Do not fail test on slow CI servers#738
Conversation
| testParallelCollectionAPICalls(); | ||
| testTaskExclusivity(); | ||
| testDeduplicationOfSubmittedTasks(); | ||
| testLongAndShortRunningParallelApiCalls(); | ||
| testFillWorkQueue(); |
There was a problem hiding this comment.
Turning the five private methods into top-level tests means they could run in different orders, so more realistic test coverage there as a side effect, nice.
From a quick read of the tests, they don't look like one could cause side effects that would change the baseline for the next tests. So changing order should be fine.
Am less sure though on whether or not the tests could run in parallel now then and if then they could interact with each other? The ones which create collections, the collection names are specific to each test, so no problem there at least.
There was a problem hiding this comment.
MAX_PARALLEL_TASKS in testFillWorkQueue() might have a cross test impact? When the queue is full, it's full.
There was a problem hiding this comment.
I guess it might just delay the other tests if running concurrently. Let's leave it like this and see if new problems appear?
There was a problem hiding this comment.
I don't think that we run tests from the same class concurrently in the same JVM, but that also seems like an implementation detail that we shouldn't rely on. Will watch for breakage.
3 participants
https://issues.apache.org/jira/browse/SOLR-16092