SOLR-15345: add fq.qparser and fq.defType alias so that filter queries#82
Closed
dweiss wants to merge 1 commit intoapache:mainfrom
Closed
SOLR-15345: add fq.qparser and fq.defType alias so that filter queries#82dweiss wants to merge 1 commit intoapache:mainfrom
dweiss wants to merge 1 commit intoapache:mainfrom
Conversation
…s can be parsed with a non-default query parser.
dsmiley
requested changes
Apr 20, 2021
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
"fq" is not only parsed by QueryComponent. Doing a find-usages on the CommonParams.FQ params turns up another semantically equivalent usages:
- RealTimeGetComponent
I looked through the others and don't think there's anything to do in those oplaces.
| * alias to {@link #FQ_QPARSER} which is aligned with the legacy {@code defType} | ||
| * parameter. {@link #FQ_QPARSER} should be preferred over this syntax. | ||
| */ | ||
| String FQ_DEFPARSER = CommonParams.FQ + ".defType"; |
Contributor
There was a problem hiding this comment.
I don't see the point in introducing fq.defType if we agree fq.qparser makes more sense?
Contributor
Author
There was a problem hiding this comment.
Thanks. Yeah, I didn't think of it - I'll take a look at those other places. I don't mind adding just one version of the parameter too (fq.qparser).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.