SOLR-16189: TestCancellableCollector thread leak#847
Merged
risdenk merged 1 commit intoapache:mainfrom May 10, 2022
Merged
Conversation
madrob
approved these changes
May 9, 2022
magibney
approved these changes
May 9, 2022
Contributor
magibney
left a comment
magibney
left a comment
There was a problem hiding this comment.
Looks good; tangential/note: as I understand it, even with this PR I'd expect occasional (though less frequent) "leaked threads" detected from this test. See recent discussion re: tryTerminate(), on SOLR-15660.
Short version: iiuc there's no built-in way to actual block for thread death on ThreadPoolExecutor.tryTerminate(), so we either need to
- accept some threshold of false positives, or
- add some minimal ThreadLeakLinger to tests involving Executors, or
- add a randomizedtesting.ThreadFilter to detect and ignore these threads if possible, a la QuickPatchThreadsFilter, or
- do some fancy ThreadFactory footwork to actually detect thread death?
Not sure 4. is worth it.
That's all orthogonal to this PR though!
Contributor
|
Thanks for taking a shot at this! |
risdenk
added a commit
that referenced
this pull request
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16189