Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented May 10, 2022

This file has recently started popping up as changed. I think it should be ignored, as it causes e.g. gradlew check -x tests to fail with "not clean checkout"

@janhoy janhoy requested review from cpoerschke, dweiss and epugh May 10, 2022 19:39
@cpoerschke
Copy link
Contributor

This file has recently started popping up as changed. ...

Interesting. My local repo does not (yet) have the file at all but instead there's some other Eclipse files which could be .gitignore-ed like this:

**/.project
**/.classpath
**/.settings/

@janhoy
Copy link
Contributor Author

janhoy commented Aug 19, 2022

Digging some more, appears that it is my gradle plugin to oh-my-zsh for Mac'sZSH that actually produces this file, probably when you type gradle<space><space>, to avoid querying task list every time, see https://github.com/ChrisCummins/oh-my-zsh/blob/master/plugins/gradle/gradle.plugin.zsh

Mac + ZSH + oh-my-zsh may be common enough for us to ignore the file, wdyt? Another option would be to check in the file, since the list of gradle tasks won't update unless build.gradle is newer than .gradletasknamecache...

Wdyt?

@janhoy
Copy link
Contributor Author

janhoy commented Aug 19, 2022

Actually the logic for when to re-generate the cache file is not sufficient to detect changes to Solr's build, since we rely on including files, so there may be a new gradle task added without the top-level build.gradle having changed. Thus users may need to nuke the cache file if it gets very old. I still think I vote for the ignore path here.

@janhoy janhoy merged commit 992b375 into apache:main Sep 14, 2022
@janhoy janhoy deleted the Ignore_gradletasknamecache branch September 14, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants