Merged
Conversation
risdenk
approved these changes
Aug 4, 2022
Contributor
|
Why not simply put the logi4j XML file into the Test-Framework.jar file? Log4j can load its config from classpath. |
Contributor
Author
|
@uschindler just tried that and yep, it seems to work just as well. Need to check if how it handles conflicts when we have xml config in test-framework and a specific module, which one wins? If that works as expected I'll revert this and do that instead. |
Contributor
|
It depends on order of classpath. Not fully sure how Gradle sets it up, but if test framework comes first in classpath it loads from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests in most of the modules, we don't get any log output because there was no logging configuration. I wonder if we could have some kind of gradle rule to validate that we have a log4j2.xml in every test-files folder?