SOLR-16331: add xml suffix to remaining managed schema files#969
Merged
epugh merged 8 commits intoapache:mainfrom Aug 10, 2022
Merged
Conversation
There isn't any reason to have a test for "managed-schema", as that isn't what this test is about.
Contributor
Author
|
I think this is ready. I left one |
dsmiley
approved these changes
Aug 10, 2022
| --> | ||
|
|
||
| <!-- This file should be called managed-schema.xml, but leaving it here to prove | ||
| that we still are backwards compatible with this format. --> |
epugh
added a commit
that referenced
this pull request
Aug 10, 2022
There is one remaining "managed-schema" in the core tests to verify backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16331
Description
Converting remaining
managed-schematomanaged-schema.xml.Solution
Please provide a short description of the approach taken to implement your solution.
Tests
ran tests and manually tested
bin/solr startcommands.