Allow skipping failure for RAT and Source Patterns#992
Conversation
gradle/validation/rat-sources.gradle
Outdated
| if (shouldFail) { | ||
| throw new GradleException(message) | ||
| } else { | ||
| logger.lifecycle("NOTE: ${message}") |
There was a problem hiding this comment.
there's a logger.warning (or warn?) method you could use here instead. otherwise lgtm.
|
Hi, |
|
Info: "When executed with --continue, Gradle will execute every task to be executed where all of the dependencies for that task completed without failure, instead of stopping as soon as the first failure is encountered. Each of the encountered failures will be reported at the end of the build. If a task fails, any subsequent tasks that were depending on it will not be executed. For example, tests will not run if there is a compilation failure in the code under test; because the test task will depend on the compilation task (either directly or indirectly)." |
|
But as check tasks are last in execution (only "check" depends on it), this is fine. |
I'd like to be able to still run these checks and report on them, but also be able to prevent them from failing the build. Useful in CI environment where I will have the output and also want to make sure other checks get run instead of failing fast here.
This pattern was modeled on the
validation.git.failOnModifiedoption.