[SPARK-14860][Tests]Create a new Waiter in reset to bypass an issue of ScalaTest's Waiter.wait#12623
Closed
zsxwing wants to merge 1 commit intoapache:masterfrom
zsxwing:flaky-test
Closed
[SPARK-14860][Tests]Create a new Waiter in reset to bypass an issue of ScalaTest's Waiter.wait#12623zsxwing wants to merge 1 commit intoapache:masterfrom zsxwing:flaky-test
zsxwing wants to merge 1 commit intoapache:masterfrom
zsxwing:flaky-test
Conversation
Member
Author
|
cc @tdas |
|
Test build #56743 has finished for PR 12623 at commit
|
Member
Author
|
ping @tdas |
Contributor
|
LGTM. Merging to master and 2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 3, 2016
…of ScalaTest's Waiter.wait
## What changes were proposed in this pull request?
This PR updates `QueryStatusCollector.reset` to create Waiter instead of calling `await(1 milliseconds)` to bypass an ScalaTest's issue that Waiter.await may block forever.
## How was this patch tested?
I created a local stress test to call codes in `test("event ordering")` 100 times. It cannot pass without this patch.
Author: Shixiong Zhu <shixiong@databricks.com>
Closes #12623 from zsxwing/flaky-test.
(cherry picked from commit b545d75)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
QueryStatusCollector.resetto create Waiter instead of callingawait(1 milliseconds)to bypass an ScalaTest's issue that Waiter.await may block forever.How was this patch tested?
I created a local stress test to call codes in
test("event ordering")100 times. It cannot pass without this patch.