Skip to content

[SPARK-14860][Tests]Create a new Waiter in reset to bypass an issue of ScalaTest's Waiter.wait #12623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 1 commit into from
Closed

[SPARK-14860][Tests]Create a new Waiter in reset to bypass an issue of ScalaTest's Waiter.wait #12623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions sql/core/src/test/scala/org/apache/spark/sql/util/ContinuousQueryListenerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ package org.apache.spark.sql.util

import java.util.concurrent.ConcurrentLinkedQueue

import scala.util.control.NonFatal

import org.scalatest.BeforeAndAfter
import org.scalatest.PrivateMethodTester._
import org.scalatest.concurrent.AsyncAssertions.Waiter
Expand Down Expand Up @@ -164,8 +162,8 @@ class ContinuousQueryListenerSuite extends StreamTest with SharedSQLContext with
}

class QueryStatusCollector extends ContinuousQueryListener {

private val asyncTestWaiter = new Waiter // to catch errors in the async listener events
// to catch errors in the async listener events
@volatile private var asyncTestWaiter = new Waiter

@volatile var startStatus: QueryStatus = null
@volatile var terminationStatus: QueryStatus = null
Expand All @@ -175,11 +173,7 @@ class ContinuousQueryListenerSuite extends StreamTest with SharedSQLContext with
startStatus = null
terminationStatus = null
progressStatuses.clear()

// To reset the waiter
try asyncTestWaiter.await(timeout(1 milliseconds)) catch {
case NonFatal(e) =>
}
asyncTestWaiter = new Waiter
}

def checkAsyncErrors(): Unit = {
Expand Down