[SPARK-18807][SPARKR] Should suppress output print for calls to JVM methods with void return values #16237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #69933 has finished for PR 16237 at commit
|
Contributor
|
Does |
Contributor
|
Actually looks like that doesn't do what we want - that checks for outputs on stdout, warnings or errors etc. |
shivaram
reviewed
Dec 9, 2016
| expect_equal(count(tables), 2) | ||
| suppressWarnings(dropTempTable("table1")) | ||
| dropTempView("table2") | ||
| expect_true(dropTempView("table2")) |
Contributor
There was a problem hiding this comment.
We have a bunch of other places where we call dropTempView - Might be good to add this to those places which we think are testing temp views ?
Contributor
|
LGTM. Will wait for Jenkins, AppVeyor |
|
Test build #69945 has finished for PR 16237 at commit
|
Contributor
|
Merging into master, branch-2.1 |
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2016
…ethods with void return values
## What changes were proposed in this pull request?
Several SparkR API calling into JVM methods that have void return values are getting printed out, especially when running in a REPL or IDE.
example:
```
> setLogLevel("WARN")
NULL
```
We should fix this to make the result more clear.
Also found a small change to return value of dropTempView in 2.1 - adding doc and test for it.
## How was this patch tested?
manually - I didn't find a expect_*() method in testthat for this
Author: Felix Cheung <felixcheung_m@hotmail.com>
Closes #16237 from felixcheung/rinvis.
(cherry picked from commit 3e11d5b)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
…ethods with void return values
## What changes were proposed in this pull request?
Several SparkR API calling into JVM methods that have void return values are getting printed out, especially when running in a REPL or IDE.
example:
```
> setLogLevel("WARN")
NULL
```
We should fix this to make the result more clear.
Also found a small change to return value of dropTempView in 2.1 - adding doc and test for it.
## How was this patch tested?
manually - I didn't find a expect_*() method in testthat for this
Author: Felix Cheung <felixcheung_m@hotmail.com>
Closes apache#16237 from felixcheung/rinvis.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ethods with void return values
## What changes were proposed in this pull request?
Several SparkR API calling into JVM methods that have void return values are getting printed out, especially when running in a REPL or IDE.
example:
```
> setLogLevel("WARN")
NULL
```
We should fix this to make the result more clear.
Also found a small change to return value of dropTempView in 2.1 - adding doc and test for it.
## How was this patch tested?
manually - I didn't find a expect_*() method in testthat for this
Author: Felix Cheung <felixcheung_m@hotmail.com>
Closes apache#16237 from felixcheung/rinvis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Several SparkR API calling into JVM methods that have void return values are getting printed out, especially when running in a REPL or IDE.
example:
We should fix this to make the result more clear.
Also found a small change to return value of dropTempView in 2.1 - adding doc and test for it.
How was this patch tested?
manually - I didn't find a expect_*() method in testthat for this