[SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSuiteBase twice#20412
Closed
zsxwing wants to merge 1 commit into
Closed
[SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSuiteBase twice#20412zsxwing wants to merge 1 commit into
zsxwing wants to merge 1 commit into
Conversation
Contributor
|
LGTM. My bad, I should caught this in the original PR that @jose-torres made. |
|
Test build #86724 has finished for PR 20412 at commit
|
Member
Author
|
retest this please |
|
Test build #4078 has finished for PR 20412 at commit
|
Member
Author
|
Thanks! Merging to master and 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Jan 27, 2018
## What changes were proposed in this pull request? KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run. ## How was this patch tested? Jenkins Author: Shixiong Zhu <zsxwing@gmail.com> Closes #20412 from zsxwing/SPARK-23242. (cherry picked from commit 0737449) Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jan 27, 2018
## What changes were proposed in this pull request? KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run. ## How was this patch tested? Jenkins Author: Shixiong Zhu <zsxwing@gmail.com> Closes apache#20412 from zsxwing/SPARK-23242.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run.
How was this patch tested?
Jenkins