[SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.#29195
Closed
ueshin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.#29195ueshin wants to merge 1 commit intoapache:masterfrom
ueshin wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Also cc @nvander1 |
|
Test build #126364 has finished for PR 29195 at commit
|
HyukjinKwon
approved these changes
Jul 23, 2020
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 13, 2021
… function ### What changes were proposed in this pull request? This PR is a follow-up of #29138 and #29195 to add more tests for `slice` function. ### Why are the changes needed? The original PRs are missing tests with column-based arguments instead of literals. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added tests and existing tests. Closes #31159 from ueshin/issues/SPARK-32338/slice_tests. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 13, 2021
… function ### What changes were proposed in this pull request? This PR is a follow-up of #29138 and #29195 to add more tests for `slice` function. ### Why are the changes needed? The original PRs are missing tests with column-based arguments instead of literals. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added tests and existing tests. Closes #31159 from ueshin/issues/SPARK-32338/slice_tests. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit ad8e40e) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #29138 which added overload
slicefunction to acceptColumnforstartandlengthin Scala.This PR is updating the equivalent Python function to accept
Columnas well.Why are the changes needed?
Now that Scala version accepts
Column, Python version should also accept it.Does this PR introduce any user-facing change?
Yes, PySpark users will also be able to pass Column object to
startandlengthparameter inslicefunction.How was this patch tested?
Added tests.