Skip to content

[SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length. #29195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 1 commit into from
Closed

[SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length. #29195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/pyspark/sql/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2068,7 +2068,11 @@ def slice(x, start, length):
[Row(sliced=[2, 3]), Row(sliced=[5])]
"""
sc = SparkContext._active_spark_context
return Column(sc._jvm.functions.slice(_to_java_column(x), start, length))
return Column(sc._jvm.functions.slice(
_to_java_column(x),
start._jc if isinstance(start, Column) else start,
length._jc if isinstance(length, Column) else length
))


@since(2.4)
Expand Down
10 changes: 10 additions & 0 deletions python/pyspark/sql/tests/test_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,16 @@ def test_input_file_name_reset_for_rdd(self):
for result in results:
self.assertEqual(result[0], '')

def test_slice(self):
from pyspark.sql.functions import slice, lit

df = self.spark.createDataFrame([([1, 2, 3],), ([4, 5],)], ['x'])

self.assertEquals(
df.select(slice(df.x, 2, 2).alias("sliced")).collect(),
df.select(slice(df.x, lit(2), lit(2)).alias("sliced")).collect(),
)

def test_array_repeat(self):
from pyspark.sql.functions import array_repeat, lit

Expand Down