[SPARK-36097][CORE] Grouping exception in core/scheduler#33529
Closed
dgd-contributor wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-36097][CORE] Grouping exception in core/scheduler#33529dgd-contributor wants to merge 3 commits intoapache:masterfrom
dgd-contributor wants to merge 3 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
dgd-contributor
changed the title
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Left a few comments. Please also resolve the merge conflict.
core/src/main/scala/org/apache/spark/errors/SparkCoreErrors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/errors/SparkCoreErrors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/errors/SparkCoreErrors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/errors/SparkCoreErrors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/errors/SparkCoreErrors.scala
Outdated
Show resolved
Hide resolved
dgd-contributor
force-pushed
the
SPARK-36097
branch
from
b78d0d7 to
e817dc2
Compare
dgd-contributor
force-pushed
the
SPARK-36097
branch
from
e817dc2 to
bbf6f65
Compare
Author
|
@allisonwang-db I've rebase and resolve all of your suggestions. Can you re-review. |
Author
|
cc @cloud-fan |
Contributor
|
@cloud-fan There are a few of these PR's, wanted to surface this comment - to make sure are interfaces are tighter. I dont want to post this in all PR's :-) |
Author
cc @allisonwang-db as well |
Author
|
cc @cloud-fan I've resolve the conflict file, can you review this |
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR group exception messages in core/src/main/scala/org/apache/spark/scheduler
Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.