[SPARK-36100][CORE] Grouping exception in core/status#33555
[SPARK-36100][CORE] Grouping exception in core/status#33555dgd-contributor wants to merge 7 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
|
I have not followed on this work, but looking at this pr a general comment, please use as specific a subclass as possible without loosing generalizability while defining interfaces. |
dgd-contributor
force-pushed
the
SPARK-36100
branch
from
a32567c to
197e629
Compare
dgd-contributor
force-pushed
the
SPARK-36100
branch
from
197e629 to
8a6bea3
Compare
dgd-contributor
force-pushed
the
SPARK-36100
branch
from
7edfb6c to
0ce644f
Compare
Yea I think this is the policy. The recent work is just to centralize all the errors into one or a few files. The error message and exception class should not be changed for now. |
| new ForbiddenException(s"""user "$user" is not authorized""") | ||
| } | ||
|
|
||
| def notFoundAppKeyError(appKey: String): Throwable = { |
| new NotFoundException(s"no such app: $appKey") | ||
| } | ||
|
|
||
| def notFoundJobIdError(jobId: Int): Throwable = { |
| new NotFoundException("No thread dump is available.") | ||
| } | ||
|
|
||
| def notFoundHttpRequestError(uri: String): Throwable = { |
| new NotFoundException(s"unknown app: $appId") | ||
| } | ||
|
|
||
| def notFoundAppWithAttemptError(appId: String, attemptId: String): Throwable = { |
There was a problem hiding this comment.
unknownAppWithAttemptError
| new NotFoundException(s"unknown attempt for stage $stageId. Found attempts: [$msg]") | ||
| } | ||
|
|
||
| def noTasksReportMetricsError(stageId: Int, stageAttemptId: Int): Throwable = { |
There was a problem hiding this comment.
noTaskReportedMetricsError
| new NotFoundException(s"No tasks reported metrics for $stageId / $stageAttemptId yet.") | ||
| } | ||
|
|
||
| def badParameterErrors(param: String, exp: String, actual: String): Throwable = { |
|
Thanks for your reviews. As we and @HyukjinKwon discussed contributing by sharing accounts, we will close this PR and recreate another by individual account. |
|
Please see PR #34191 |
6 participants
What changes were proposed in this pull request?
This PR group exception messages in core/src/main/scala/org/apache/spark/status
Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.