Skip to content

[SPARK-42609][CONNECT][TESTS] Add tests for grouping() and grouping_id() functions#40259

Closed
amaliujia wants to merge 2 commits intoapache:masterfrom
amaliujia:rw-test-grouping-groupingset
Closed

[SPARK-42609][CONNECT][TESTS] Add tests for grouping() and grouping_id() functions#40259
amaliujia wants to merge 2 commits intoapache:masterfrom
amaliujia:rw-test-grouping-groupingset

Conversation

@amaliujia
Copy link
Contributor

What changes were proposed in this pull request?

Add tests for grouping() and grouping_id() functions.

Why are the changes needed?

Improve testing coverage.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

UT

@amaliujia
Copy link
Contributor Author

@hvanhovell

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaliujia amaliujia force-pushed the rw-test-grouping-groupingset branch from 6e3f92c to eafcb8f Compare March 3, 2023 05:42
@zhengruifeng zhengruifeng changed the title [SPARK-42609][CONNECT] Add tests for grouping() and grouping_id() functions [SPARK-42609][CONNECT][TESTS] Add tests for grouping() and grouping_id() functions Mar 3, 2023
zhengruifeng pushed a commit that referenced this pull request Mar 3, 2023
…d() functions

### What changes were proposed in this pull request?

Add tests for grouping() and grouping_id() functions.

### Why are the changes needed?

Improve testing coverage.

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

UT

Closes #40259 from amaliujia/rw-test-grouping-groupingset.

Authored-by: Rui Wang <rui.wang@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 6874fd1)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
@zhengruifeng
Copy link
Contributor

merged into master/3.4

snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
…d() functions

### What changes were proposed in this pull request?

Add tests for grouping() and grouping_id() functions.

### Why are the changes needed?

Improve testing coverage.

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

UT

Closes apache#40259 from amaliujia/rw-test-grouping-groupingset.

Authored-by: Rui Wang <rui.wang@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 6874fd1)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants