Skip to content

Add comment about defaultMinPartitions - #4102

Closed
idanz wants to merge 1 commit into
apache:masterfrom
idanz:patch-2
Closed

Add comment about defaultMinPartitions#4102
idanz wants to merge 1 commit into
apache:masterfrom
idanz:patch-2

Conversation

@idanz

@idanz idanz commented Jan 19, 2015

Copy link
Copy Markdown
Contributor

Added a comment about using math.min for choosing default partition count

Added a comment about using math.min for choosing default partition count
@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@srowen

srowen commented Jan 19, 2015

Copy link
Copy Markdown
Member

(Can you make the description descriptive? it becomes a commit message.)

@idanz idanz changed the title Update SparkContext.scala Add comment about defaultMinPartitions Jan 19, 2015
@JoshRosen

Copy link
Copy Markdown
Contributor

Jenkins, this is ok to test.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25906 has started for PR 4102 at commit 50e9d58.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25906 has finished for PR 4102 at commit 50e9d58.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25906/
Test FAILed.

@JoshRosen

Copy link
Copy Markdown
Contributor

This is a spurious test failure: it looks like a test using EasyMock failed during test suite initialization, which leaked a SparkContext and triggered this error.

@JoshRosen

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25914 has started for PR 4102 at commit 50e9d58.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25914 has finished for PR 4102 at commit 50e9d58.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25914/
Test FAILed.

@JoshRosen

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25921 has started for PR 4102 at commit 50e9d58.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Jan 21, 2015

Copy link
Copy Markdown

Test build #25921 has finished for PR 4102 at commit 50e9d58.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25921/
Test PASSed.

@JoshRosen

Copy link
Copy Markdown
Contributor

I'm going to merge this into master (1.3.0) and leave a note on the JIRA to say that this has been addressed in the documentation. Thanks!

@asfgit asfgit closed this in 412a58e Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants