Skip to content

[SPARK-44023][SQL][TESTS] Add System.gc at beforeEach in PruneFileSourcePartitionsSuite #41533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 7 commits into from
Closed

[SPARK-44023][SQL][TESTS] Add System.gc at beforeEach in PruneFileSourcePartitionsSuite #41533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6704065
add system gc in PruneFileSourcePartitionsSuite
LuciferYang Jun 11, 2023
4bd78fd
Merge branch 'apache:master' into GA-test
LuciferYang Jun 11, 2023
cb95fe4
for ga
LuciferYang Jun 11, 2023
5e207c7
Merge branch 'apache:master' into GA-test
LuciferYang Jun 12, 2023
0ba8e6a
for ga
LuciferYang Jun 12, 2023
4a2cd26
ignore AlterTableRenamePartitionSuite
LuciferYang Jun 12, 2023
66a2b49
Merge branch 'apache:master' into GA-test
LuciferYang Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...test/scala/org/apache/spark/sql/execution/command/v2/AlterTableRenamePartitionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@

package org.apache.spark.sql.execution.command.v2

import org.scalatest.Ignore

import org.apache.spark.sql.Row
import org.apache.spark.sql.execution.command

/**
* The class contains tests for the `ALTER TABLE .. RENAME PARTITION` command
* to check V2 table catalogs.
*/
@Ignore
Copy link
Contributor Author

@LuciferYang LuciferYang Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although GA passed, I am not sure we really need ignore this case ...

Copy link
Member

@HyukjinKwon HyukjinKwon Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ignore it for now.

class AlterTableRenamePartitionSuite
extends command.AlterTableRenamePartitionSuiteBase
with CommandSuiteBase {
Expand Down
5 changes: 5 additions & 0 deletions ...est/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ import org.apache.spark.sql.types.StructType

class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase with SharedSparkSession {

override def beforeEach(): Unit = {
Copy link
Contributor Author

@LuciferYang LuciferYang Jun 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if this is really useful @HyukjinKwon @zhengruifeng

super.beforeEach()
System.gc()
}

override def format: String = "parquet"

object Optimize extends RuleExecutor[LogicalPlan] {
Expand Down