[SPARK-44045][SQL][TESTS] Mark WholeStageCodegenSparkSubmitSuite as ExtendedSQLTest#41579
[SPARK-44045][SQL][TESTS] Mark WholeStageCodegenSparkSubmitSuite as ExtendedSQLTest#41579dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-44045
WholeStageCodegenSparkSubmitSuite as ExtendedSQLTest#41579Conversation
… `ExtendedSQLTest`
|
cc @HyukjinKwon , @LuciferYang , @viirya |
viirya
left a comment
There was a problem hiding this comment.
I'm wondering why moving to sql - slow pipeline can mitigate flakiness?
|
Thank you for review. The pipeline is flaky due to |
|
BTW, I must say that this is not the only reason why the |
viirya
left a comment
There was a problem hiding this comment.
Got it. Okay, I think we can try this and see if it can mitigate the issue.
|
Thank you! |
|
I verified that it's moved into https://github.com/dongjoon-hyun/spark/actions/runs/5259819811/jobs/9505917572 |
|
Merged to master. |
|
late LGTM |
|
LGTM2 |
|
Thank you, @LuciferYang and @HyukjinKwon ! |
|
late LGTM |
|
Now, it seems to be much better although it's still too early to say. Two commits (SPARK-44045 and SPARK-44021) passes the tests without flakiness.
|
… `ExtendedSQLTest` ### What changes were proposed in this pull request? This PR aims to move `WholeStageCodegenSparkSubmitSuite` to `sql - slow` pipeline to mitigate the recent `sql - others` pipeline's flakiness. ### Why are the changes needed? `WholeStageCodegenSparkSubmitSuite` is the only test suite using `SparkSubmitTestUtils` in `sql` module. ``` $ git grep 'SparkSubmitTestUtils' | grep sql/core sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSparkSubmitSuite.scala:import org.apache.spark.deploy.SparkSubmitTestUtils sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSparkSubmitSuite.scala:class WholeStageCodegenSparkSubmitSuite extends SparkSubmitTestUtils ``` Like the following, this test case contributes the flakiness. - https://github.com/wangyum/spark/actions/runs/5253058423/jobs/9489919333 ``` 2023-06-13T11:05:31.3387316Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32mWholeStageCodegenSparkSubmitSuite:�[0m�[0m 2023-06-13T11:05:36.6680896Z 2023-06-13 04:05:36.667 - stderr> 23/06/13 11:05:36 INFO SparkContext: Running Spark version 3.5.0-SNAPSHOT ... 2023-06-13T11:06:47.4402222Z 2023-06-13 04:06:47.408 - stderr> 23/06/13 11:06:47 INFO TaskSetManager: Finished task 52.0 in stage 2.0 (TID 63) in 148 ms on 127.0.0.1 (executor 0) (60/200) 2023-06-13T11:06:48.1484169Z 2023-06-13T11:06:48.8633864Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled. 2023-06-13T11:06:48.9660849Z Session terminated, killing shell... 2023-06-13T11:06:49.2756183Z ##[error]The operation was canceled. 2023-06-13T11:06:49.4597252Z Cleaning up orphan processes 2023-06-13T11:06:49.6684941Z Terminate orphan process: pid (4061) (java) 2023-06-13T11:06:49.7698091Z Terminate orphan process: pid (661115) (java) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41579 from dongjoon-hyun/SPARK-44045. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
… `ExtendedSQLTest` ### What changes were proposed in this pull request? This PR aims to move `WholeStageCodegenSparkSubmitSuite` to `sql - slow` pipeline to mitigate the recent `sql - others` pipeline's flakiness. ### Why are the changes needed? `WholeStageCodegenSparkSubmitSuite` is the only test suite using `SparkSubmitTestUtils` in `sql` module. ``` $ git grep 'SparkSubmitTestUtils' | grep sql/core sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSparkSubmitSuite.scala:import org.apache.spark.deploy.SparkSubmitTestUtils sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSparkSubmitSuite.scala:class WholeStageCodegenSparkSubmitSuite extends SparkSubmitTestUtils ``` Like the following, this test case contributes the flakiness. - https://github.com/wangyum/spark/actions/runs/5253058423/jobs/9489919333 ``` 2023-06-13T11:05:31.3387316Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32mWholeStageCodegenSparkSubmitSuite:�[0m�[0m 2023-06-13T11:05:36.6680896Z 2023-06-13 04:05:36.667 - stderr> 23/06/13 11:05:36 INFO SparkContext: Running Spark version 3.5.0-SNAPSHOT ... 2023-06-13T11:06:47.4402222Z 2023-06-13 04:06:47.408 - stderr> 23/06/13 11:06:47 INFO TaskSetManager: Finished task 52.0 in stage 2.0 (TID 63) in 148 ms on 127.0.0.1 (executor 0) (60/200) 2023-06-13T11:06:48.1484169Z 2023-06-13T11:06:48.8633864Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled. 2023-06-13T11:06:48.9660849Z Session terminated, killing shell... 2023-06-13T11:06:49.2756183Z ##[error]The operation was canceled. 2023-06-13T11:06:49.4597252Z Cleaning up orphan processes 2023-06-13T11:06:49.6684941Z Terminate orphan process: pid (4061) (java) 2023-06-13T11:06:49.7698091Z Terminate orphan process: pid (661115) (java) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41579 from dongjoon-hyun/SPARK-44045. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

What changes were proposed in this pull request?
This PR aims to move
WholeStageCodegenSparkSubmitSuitetosql - slowpipeline to mitigate the recentsql - otherspipeline's flakiness.Why are the changes needed?
WholeStageCodegenSparkSubmitSuiteis the only test suite usingSparkSubmitTestUtilsinsqlmodule.Like the following, this test case contributes the flakiness.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.