[SPARK-46028][CONNECT][PYTHON] Make Column.__getitem__ accept input column#43930
Closed
zhengruifeng wants to merge 1 commit into
Closed
[SPARK-46028][CONNECT][PYTHON] Make Column.__getitem__ accept input column#43930zhengruifeng wants to merge 1 commit into
Column.__getitem__ accept input column#43930zhengruifeng wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Nov 21, 2023
dongjoon-hyun
approved these changes
Nov 21, 2023
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @zhengruifeng and @HyukjinKwon .
Merged to master for Apache Spark 4.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
Column.__getitem__accept input columnWhy are the changes needed?
Column.__getitem__should accept column as inputDoes this PR introduce any user-facing change?
yes
How was this patch tested?
added ut
Was this patch authored or co-authored using generative AI tooling?
no