Skip to content

[SPARK-46028][CONNECT][PYTHON] Make Column.__getitem__ accept input column #43930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-46028][CONNECT][PYTHON] Make Column.__getitem__ accept input column #43930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/pyspark/sql/connect/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,8 @@ def __getitem__(self, k: Any) -> "Column":
message_parameters={},
)
return self.substr(k.start, k.stop)
elif isinstance(k, Column):
return Column(UnresolvedExtractValue(self._expr, k._expr))
else:
return Column(UnresolvedExtractValue(self._expr, LiteralExpression._from_value(k)))

Expand Down
11 changes: 11 additions & 0 deletions python/pyspark/sql/tests/test_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
# limitations under the License.
#

from itertools import chain
from pyspark.sql import Column, Row
from pyspark.sql import functions as sf
from pyspark.sql.types import StructType, StructField, LongType
from pyspark.errors import AnalysisException, PySparkTypeError
from pyspark.testing.sqlutils import ReusedSQLTestCase
Expand Down Expand Up @@ -207,6 +209,15 @@ def test_drop_fields(self):

self.assertTrue("e" not in result["a2"]["d"] and "f" in result["a2"]["d"])

def test_getitem_column(self):
mapping = {"A": "20", "B": "28", "C": "34"}
mapping_expr = sf.create_map([sf.lit(x) for x in chain(*mapping.items())])
df = self.spark.createDataFrame(
data=[["A", "10"], ["B", "14"], ["C", "17"]],
schema=["key", "value"],
).withColumn("square_value", mapping_expr[sf.col("key")])
self.assertEqual(df.count(), 3)


class ColumnTests(ColumnTestsMixin, ReusedSQLTestCase):
pass
Expand Down