[SPARK-47341][Connect] Replace commands with relations in a few tests in SparkConnectClientSuite#45460
Closed
xi-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47341][Connect] Replace commands with relations in a few tests in SparkConnectClientSuite#45460xi-db wants to merge 1 commit intoapache:masterfrom
xi-db wants to merge 1 commit intoapache:masterfrom
Conversation
xi-db
changed the title
xi-db
changed the title
xi-db
changed the title
HyukjinKwon
approved these changes
Mar 11, 2024
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A few tests in SparkConnectClientSuite attempt to test the result collection of a reattachable execution through the use of a SQL command. The SQL command, on a real server, is not executed eagerly (since it is a select command) and thus, is not entirely accurate. The test itself is non-problematic since a dummy server with dummy responses is used but a small improvement here would be to construct a relation rather than a command.
Why are the changes needed?
Although these tests are not problematic, we should ensure that the behavior of the tests is consistent with the actual behavior of real servers to avoid misleading developers.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The tests in org.apache.spark.sql.connect.client.SparkConnectClientSuite passed.
Was this patch authored or co-authored using generative AI tooling?
No.