Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 17, 2024

What changes were proposed in this pull request?

This PR aims to upgrade

  • grpcio and grpcio-status to 1.67.0
  • grpc-java to 1.67.1

Please note that grpc-java there is no 1.67.0 and 1.68.0 is wrong as announced like the following.

There was no 1.67.0 release. There was a problem making the release and it went to Maven Central as 1.68.0 instead.

Why are the changes needed?

To use the latest updated versions as a part of Apache Spark 4.0.0 (February 2025) preparation.

Does this PR introduce any user-facing change?

Although this is a dependency change, it should be backward compatible.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 17, 2024 18:29
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 18, 2024 21:30
@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 18, 2024 21:30
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 24, 2024 14:37
@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 25, 2024 00:52
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 25, 2024 17:31
@dongjoon-hyun
Copy link
Member Author

All tests passed. Thank you, @yaooqinn .
Merged to master for Apache Spark 4.0.0 on February 2025.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50015 branch October 25, 2024 18:03
HyukjinKwon added a commit that referenced this pull request Oct 31, 2024
…Python client 3.5 <> 4.0 server

### What changes were proposed in this pull request?

This PR proposes to use the same latest Python dependencies in Python client 3.5 <> 4.0 server build. This is a sort of a followup of #48524.

### Why are the changes needed?

https://github.com/apache/spark/actions/runs/11543780375/job/32128570166 fails apparently because of different grpc versions. While it is a legitimate failure to fix, that CI does not target to test all different dependency versions. It only targets 3.5cleint <> 4.0server. We should better make the test on its purpose.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Will monitor the jobs

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #48719 from HyukjinKwon/SPARK-50015-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…sion` to 1.67.0

### What changes were proposed in this pull request?

This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly.

https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211

https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76

### Why are the changes needed?

It seems that we missed to this at
- #44929
- #48524

### Does this PR introduce _any_ user-facing change?

This will make it sure that PySpark Connect installation meets the minimum requirement correctly.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49968 from dongjoon-hyun/SPARK-51227.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…sion` to 1.67.0

### What changes were proposed in this pull request?

This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly.

https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211

https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76

### Why are the changes needed?

It seems that we missed to this at
- #44929
- #48524

### Does this PR introduce _any_ user-facing change?

This will make it sure that PySpark Connect installation meets the minimum requirement correctly.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49968 from dongjoon-hyun/SPARK-51227.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 3f4ba72)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon added a commit that referenced this pull request Feb 24, 2025
…p.py for pyspark-client

### What changes were proposed in this pull request?

This PR is a followup of #48524 that updates _minimum_grpc_version in setup.py for pyspark-client

### Why are the changes needed?

To match the version with pyspark.

### Does this PR introduce _any_ user-facing change?

No, `pyspark-client` has not been released yet.

### How was this patch tested?

It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #50064 from HyukjinKwon/SPARK-50015-followup2.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon added a commit that referenced this pull request Feb 24, 2025
…p.py for pyspark-client

### What changes were proposed in this pull request?

This PR is a followup of #48524 that updates _minimum_grpc_version in setup.py for pyspark-client

### Why are the changes needed?

To match the version with pyspark.

### Does this PR introduce _any_ user-facing change?

No, `pyspark-client` has not been released yet.

### How was this patch tested?

It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #50064 from HyukjinKwon/SPARK-50015-followup2.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ee8e10f)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
…sion` to 1.67.0

### What changes were proposed in this pull request?

This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly.

https://github.com/apache/spark/blob/acc254463533b863b8afe8dccad6565bbff9e35c/python/docs/source/getting_started/install.rst?plain=1#L211

https://github.com/apache/spark/blob/acc254463533b863b8afe8dccad6565bbff9e35c/dev/spark-test-image/python-minimum/Dockerfile#L76

### Why are the changes needed?

It seems that we missed to this at
- apache#44929
- apache#48524

### Does this PR introduce _any_ user-facing change?

This will make it sure that PySpark Connect installation meets the minimum requirement correctly.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49968 from dongjoon-hyun/SPARK-51227.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 52fc668)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
…p.py for pyspark-client

### What changes were proposed in this pull request?

This PR is a followup of apache#48524 that updates _minimum_grpc_version in setup.py for pyspark-client

### Why are the changes needed?

To match the version with pyspark.

### Does this PR introduce _any_ user-facing change?

No, `pyspark-client` has not been released yet.

### How was this patch tested?

It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#50064 from HyukjinKwon/SPARK-50015-followup2.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit fc80f49)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants