[SPARK-50106][PYTHON] Upgrade protobuf Python package to 5.28.3
#48644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-50106
branch
from
3a3b755 to
dbcf26c
Compare
dongjoon-hyun
changed the title
protobuf Python package to 5.28.3protobuf Python package to 5.28.3 and protobuf-java to 4.28.3
dongjoon-hyun
force-pushed
the
SPARK-50106
branch
from
dbcf26c to
ff80be2
Compare
dongjoon-hyun
changed the title
protobuf Python package to 5.28.3 and protobuf-java to 4.28.3protobuf Python package to 5.28.3
dongjoon-hyun
changed the title
protobuf Python package to 5.28.3protobuf Python package to 5.28.3
Member
Author
|
cc @HyukjinKwon |
Member
Author
|
All tests passed. |
Member
Author
|
Could you review this PR too, @zhengruifeng and @xinrong-meng ? |
Member
Author
|
Could you review this PR, @viirya ? |
HyukjinKwon
approved these changes
Oct 25, 2024
Member
Author
|
Thank you, @HyukjinKwon . Merged to master for Apache Spark 4.0.0 on February 2025. |
Member
Author
|
Thank you, @viirya . |
HyukjinKwon
added a commit
that referenced
this pull request
Nov 5, 2024
…ents.txt ### What changes were proposed in this pull request? This PR proposes to add 'protobuf==5.28.3' in `dev/requirements.txt`. If you have an old version in your env, you would face an error like: ``` google.protobuf.runtime_version.VersionError: Detected incompatible Protobuf Gencode/Runtime versions when loading spark/connect/base.proto: gencode 5.28.3 runtime 5.28.2. Runtime version cannot be older than the linked gencode version. See Protobuf version guarantees at https://protobuf.dev/support/cross-version-runtime-guarantee. ``` This PR is a sort of a followup of #48644 ### Why are the changes needed? So developers can easily set up their env. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually installed and tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48763 from HyukjinKwon/note-protobuf. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
protobufPython package from4.25.1to5.28.3for Apache Spark 4.0.0 on February 2025.Why are the changes needed?
To bring the latest bug fixes and support
Python 3.13which requiresgrpcio*>=1.66.2(grpcio-status>=1.66.2requiresprotobuf>=5.26.1).Does this PR introduce any user-facing change?
This is a dependency change with no behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.