[SPARK-50701][PYTHON] Make plotting require the minimum plotly version#49333
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-50701][PYTHON] Make plotting require the minimum plotly version#49333zhengruifeng wants to merge 2 commits intoapache:masterfrom
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
zhengruifeng
force-pushed
the
py_plot_minimum_version
branch
from
be7e798 to
238a497
Compare
HyukjinKwon
reviewed
Dec 31, 2024
| ) | ||
|
|
||
|
|
||
| def require_minimum_plotly_version() -> None: |
Member
There was a problem hiding this comment.
Hm, don't we also support plot in the plain DataFrame.plot too? Then it should stay here
Contributor
Author
There was a problem hiding this comment.
this require_minimum_plotly_version is only used for plain DF.plot
Contributor
Author
There was a problem hiding this comment.
make sense, let me keep it in the file
HyukjinKwon
approved these changes
Dec 31, 2024
Contributor
Author
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make plotting require the minimum plotly version
Why are the changes needed?
the
minimum_plotly_version = "4.8"didn't take effect in existing implementationDoes this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No