Skip to content

[SPARK-50701][PYTHON] Make plotting require the minimum plotly version #49333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 2 commits into from
Closed

[SPARK-50701][PYTHON] Make plotting require the minimum plotly version #49333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238a497
fix
zhengruifeng Dec 27, 2024
7fc6809
address comments
zhengruifeng Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions python/pyspark/sql/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,34 @@ def require_test_compiled() -> None:

def require_minimum_plotly_version() -> None:
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, don't we also support plot in the plain DataFrame.plot too? Then it should stay here

Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xinrong-meng

Copy link
Copy Markdown
Contributor Author

@zhengruifeng zhengruifeng Dec 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this require_minimum_plotly_version is only used for plain DF.plot

Copy link
Copy Markdown
Contributor Author

@zhengruifeng zhengruifeng Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, let me keep it in the file

"""Raise ImportError if plotly is not installed"""
from pyspark.loose_version import LooseVersion

minimum_plotly_version = "4.8"

try:
import plotly # noqa: F401
import plotly

have_plotly = True
except ImportError as error:
have_plotly = False
raised_error = error
if not have_plotly:
raise PySparkImportError(
errorClass="PACKAGE_NOT_INSTALLED",
messageParameters={
"package_name": "plotly",
"package_name": "Plotly",
"minimum_version": str(minimum_plotly_version),
},
) from error
) from raised_error
if LooseVersion(plotly.__version__) < LooseVersion(minimum_plotly_version):
raise PySparkImportError(
errorClass="UNSUPPORTED_PACKAGE_VERSION",
messageParameters={
"package_name": "Plotly",
"minimum_version": str(minimum_plotly_version),
"current_version": str(plotly.__version__),
},
)


class ForeachBatchFunction:
Expand Down