[SPARK-50831][SQL] Enable trimming collation by default#49510
[SPARK-50831][SQL] Enable trimming collation by default#49510stevomitric wants to merge 3 commits intoapache:masterfrom
Conversation
|
cc @stefankandic and @dejankrak-db |
stefankandic
left a comment
stefankandic
left a comment
There was a problem hiding this comment.
LGTM, I would also like a confirmation from @jovanpavl-db just to double check that there are no blockers for enabling this by default
|
jovanpavl-db
left a comment
jovanpavl-db
left a comment
There was a problem hiding this comment.
Keep in mind that there are some tests added when introducing this feature flag that needs to be removed, take a look at:
https://github.com/apache/spark/pull/48222/files
| .version("4.0.0") | ||
| .booleanConf | ||
| .createWithDefault(Utils.isTesting) | ||
| .createWithDefault(true) |
There was a problem hiding this comment.
Oh, wait.
Do we need to revise the doc?
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Lines 878 to 879 in 9841ae2
There was a problem hiding this comment.
The development is finished, isn't it?
|
Gentle ping, @stevomitric . |
|
+1, LGTM. Merging to master. |
|
Thank you all! |
5 participants
What changes were proposed in this pull request?
Changed the sql config to enable the trimming collation by default.
Why are the changes needed?
As per the collation project plan.
Does this PR introduce any user-facing change?
Yes, the trimming collation will be enabled by default.
How was this patch tested?
Existing trimming tests.
Was this patch authored or co-authored using generative AI tooling?
No