Skip to content

[SPARK-50831][SQL] Enable trimming collation by default #49510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevomitric wants to merge 3 commits into from
Closed

[SPARK-50831][SQL] Enable trimming collation by default #49510

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
385ba48
Enable trimming collations by default
stevomitric Jan 15, 2025
683dd74
change message
stevomitric Jan 16, 2025
9611ba6
fix grammer
stevomitric Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,13 +874,12 @@ object SQLConf {
lazy val TRIM_COLLATION_ENABLED =
buildConf("spark.sql.collation.trim.enabled")
.internal()
.doc(
"Trim collation feature is under development and its use should be done under this" +
"feature flag. Trim collation trims trailing whitespaces from strings."
.doc("When enabled allows the use of trim collations which trim trailing whitespaces from" +
" strings."
)
.version("4.0.0")
.booleanConf
.createWithDefault(Utils.isTesting)
.createWithDefault(true)
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait.

Do we need to revise the doc?

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

Lines 878 to 879 in 9841ae2

"Trim collation feature is under development and its use should be done under this" +
"feature flag. Trim collation trims trailing whitespaces from strings."

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The development is finished, isn't it?

Copy link
Copy Markdown
Contributor Author

@stevomitric stevomitric Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the message. cc @dongjoon-hyun


val DEFAULT_COLLATION =
buildConf(SqlApiConfHelper.DEFAULT_COLLATION)
Expand Down