[SPARK-53906][K8S] Protect ExecutorPodsAllocator.numOutstandingPods as protected val
#52614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as `protected val`
Member
Author
|
cc @peter-toth |
peter-toth
approved these changes
Oct 14, 2025
Member
Author
|
Thank you so much, @peter-toth . |
Member
Author
|
Merged to master for Apache Spark 4.1.0-preview3. |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 23, 2025
…ndingPods` ### What changes were proposed in this pull request? This is a follow-up of the following to apply the latest `master` branch change. - #51913 ### Why are the changes needed? The master branch compilation is broken currently. - https://github.com/apache/spark/actions/runs/18760939731 Recently, we changed `numOutstandingPods`'s visibility, but I missed that the old open PRs didn't have this change. - #52614 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52714 from dongjoon-hyun/SPARK-53324. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
… as `protected val` ### What changes were proposed in this pull request? This PR aims to protect `ExecutorPodsAllocator.numOutstandingPods` as `protected val`. ### Why are the changes needed? We had better protect this properly instead of commenting it. https://github.com/apache/spark/blob/ff0f1ab95238b27af93c755b600b82c0769fb8d0/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala#L108-L109 ### Does this PR introduce _any_ user-facing change? No. This is not supposed to be used internally. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52614 from dongjoon-hyun/SPARK-53906. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ndingPods` ### What changes were proposed in this pull request? This is a follow-up of the following to apply the latest `master` branch change. - apache#51913 ### Why are the changes needed? The master branch compilation is broken currently. - https://github.com/apache/spark/actions/runs/18760939731 Recently, we changed `numOutstandingPods`'s visibility, but I missed that the old open PRs didn't have this change. - apache#52614 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52714 from dongjoon-hyun/SPARK-53324. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to protect
ExecutorPodsAllocator.numOutstandingPodsasprotected val.Why are the changes needed?
We had better protect this properly instead of commenting it.
spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
Lines 108 to 109 in ff0f1ab
Does this PR introduce any user-facing change?
No. This is not supposed to be used internally.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.