[SPARK-53324][K8S][FOLLOWUP] Use invokePrivate to access numOutstandingPods
#52714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
numOutstandingPodsinvokePrivate to access numOutstandingPods
Member
Author
|
Could you review this PR, @gengliangwang ? Unfortunately, I broke the master branch compilation at the last merging. |
Member
Author
|
I verified this manually too. |
sarutak
approved these changes
Oct 23, 2025
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
LGTM. Let's merge to recover CI.
Member
Author
|
Thank you so much for your quick help, @sarutak ! |
gengliangwang
approved these changes
Oct 23, 2025
Member
Author
|
Thank you, @gengliangwang too! Merged to master. |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ndingPods` ### What changes were proposed in this pull request? This is a follow-up of the following to apply the latest `master` branch change. - apache#51913 ### Why are the changes needed? The master branch compilation is broken currently. - https://github.com/apache/spark/actions/runs/18760939731 Recently, we changed `numOutstandingPods`'s visibility, but I missed that the old open PRs didn't have this change. - apache#52614 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52714 from dongjoon-hyun/SPARK-53324. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of the following to apply the latest
masterbranch change.Why are the changes needed?
The master branch compilation is broken currently.
Recently, we changed
numOutstandingPods's visibility, but I missed that the old open PRs didn't have this change.ExecutorPodsAllocator.numOutstandingPodsasprotected val#52614Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.