Skip to content

[SPARK-53324][K8S][FOLLOWUP] Use invokePrivate to access numOutstandingPods #52714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-53324][K8S][FOLLOWUP] Use invokePrivate to access numOutstandingPods #52714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...re/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter {
// Request more than the max per rp for one rp
podsAllocatorUnderTest.setTotalExpectedExecutors(Map(defaultProfile -> 2, rp -> 3))
// 2 for default, and 2 for rp
assert(podsAllocatorUnderTest.numOutstandingPods.get() == 4)
assert(podsAllocatorUnderTest.invokePrivate(numOutstandingPods).get() == 4)
verify(podsWithNamespace).resource(podWithAttachedContainerForId(1, defaultProfile.id))
verify(podsWithNamespace).resource(podWithAttachedContainerForId(2, defaultProfile.id))
verify(podsWithNamespace).resource(podWithAttachedContainerForId(3, rp.id))
Expand All @@ -285,7 +285,7 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter {
snapshotsStore.updatePod(pendingExecutor(2, defaultProfile.id))
snapshotsStore.updatePod(pendingExecutor(3, rp.id))
snapshotsStore.notifySubscribers()
assert(podsAllocatorUnderTest.numOutstandingPods.get() == 4)
assert(podsAllocatorUnderTest.invokePrivate(numOutstandingPods).get() == 4)
verify(podResource, times(4)).create()
verify(labeledPods, never()).delete()

Expand All @@ -294,14 +294,14 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter {
waitForExecutorPodsClock.advance(executorIdleTimeout * 2)
podsAllocatorUnderTest.setTotalExpectedExecutors(Map(defaultProfile -> 1, rp -> 3))
snapshotsStore.notifySubscribers()
assert(podsAllocatorUnderTest.numOutstandingPods.get() == 3)
assert(podsAllocatorUnderTest.invokePrivate(numOutstandingPods).get() == 3)
verify(labeledPods, times(1)).delete()

// Make one pod running from non-default rp so we have one more slot for pending pods.
snapshotsStore.updatePod(runningExecutor(3, rp.id))
snapshotsStore.updatePod(pendingExecutor(4, rp.id))
snapshotsStore.notifySubscribers()
assert(podsAllocatorUnderTest.numOutstandingPods.get() == 3)
assert(podsAllocatorUnderTest.invokePrivate(numOutstandingPods).get() == 3)
verify(podsWithNamespace).resource(podWithAttachedContainerForId(5, rp.id))
verify(labeledPods, times(1)).delete()
}
Expand Down