[SPARK-54063][SS][FOLLOWUP] Remove withTempDirFix from forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test
#53141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @zifeif2 . I verified locally.
dongjoon-hyun
changed the title
withTempDirFix from SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test
dongjoon-hyun
changed the title
withTempDirFix from SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true testwithTempDirFix from SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test
dongjoon-hyun
changed the title
withTempDirFix from SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true testwithTempDirFix from forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test
Member
|
I verified manually both test suites with/without |
Member
|
To make it sure, I triggered the CI here. |
Member
|
Thanks for the quick fix, @zifeif2 ! |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 25, 2025
…ot metric populated when shouldForceSnapshotOnCommit is true` test
### What changes were proposed in this pull request?
Remove `withTempDir` in `test("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true")` because it breaks RocksDB UI Backend CI by causing a timeout https://github.com/apache/spark/actions/runs/19527445536/job/55950300126
### Why are the changes needed?
See above
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#53141 from zifeif2/fix-trigger-test.
Authored-by: Ubuntu <zifei.feng@your.hostname.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ot metric populated when shouldForceSnapshotOnCommit is true` test
### What changes were proposed in this pull request?
Remove `withTempDir` in `test("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true")` because it breaks RocksDB UI Backend CI by causing a timeout https://github.com/apache/spark/actions/runs/19527445536/job/55950300126
### Why are the changes needed?
See above
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#53141 from zifeif2/fix-trigger-test.
Authored-by: Ubuntu <zifei.feng@your.hostname.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
withTempDirintest("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true")because it breaks RocksDB UI Backend CI by causing a timeout https://github.com/apache/spark/actions/runs/19527445536/job/55950300126Why are the changes needed?
See above
Does this PR introduce any user-facing change?
No
How was this patch tested?
No
Was this patch authored or co-authored using generative AI tooling?
No