Skip to content

[SPARK-54063][SS][FOLLOWUP] Remove withTempDirFix from forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test #53141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-54063][SS][FOLLOWUP] Remove withTempDirFix from forceSnapshot metric populated when shouldForceSnapshotOnCommit is true test #53141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e1bdb2
initial commit
Nov 20, 2025
0ca91a6
change indentation
Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2736,19 +2736,17 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider]
}

test("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true") {
withTempDir { dir =>
tryWithProviderResource(newStoreProvider()) { provider =>
val store = provider.getStore(0, forceSnapshotOnCommit = true)
put(store, "a", 0, 1)
store.commit()
// Verify that a snapshot file was created for version 1
val metricPair = store.metrics.customMetrics.find { case (metric, _) =>
metric.name.contains("rocksdbForceSnapshotCount") ||
metric.name.contains("forceSnapshotCount")
}
assert(metricPair.isDefined)
assert(metricPair.get._2 == 1L, s"forceSnapshot should be 1 but was ${metricPair.get._2}")
tryWithProviderResource(newStoreProvider()) { provider =>
val store = provider.getStore(0, forceSnapshotOnCommit = true)
put(store, "a", 0, 1)
store.commit()
// Verify that a snapshot file was created for version 1
val metricPair = store.metrics.customMetrics.find { case (metric, _) =>
metric.name.contains("rocksdbForceSnapshotCount") ||
metric.name.contains("forceSnapshotCount")
}
assert(metricPair.isDefined)
assert(metricPair.get._2 == 1L, s"forceSnapshot should be 1 but was ${metricPair.get._2}")
}
}

Expand Down