[SPARK-56889][INFRA][FOLLOWUP] Install python3-pyparsing before add-apt-repository#55956
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-56889][INFRA][FOLLOWUP] Install python3-pyparsing before add-apt-repository#55956dongjoon-hyun wants to merge 1 commit into
python3-pyparsing before add-apt-repository#55956dongjoon-hyun wants to merge 1 commit into
Conversation
…d-apt-repository`
This was referenced May 18, 2026
Member
Author
|
cc @zhengruifeng , @LuciferYang , @peter-toth |
LuciferYang
approved these changes
May 18, 2026
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
LGTM if this can be fixed fundamentally.
Member
Author
|
Thank you, @LuciferYang . Since this is a CI issue, let me merge to validate this. We can still keep @zhengruifeng 's PR as a fallback. |
dongjoon-hyun
added a commit
that referenced
this pull request
May 18, 2026
…d-apt-repository` ### What changes were proposed in this pull request? This PR aims to install `python3-pyparsing` before invoking `add-apt-repository`. ### Why are the changes needed? To avoid `ModuleNotFoundError: No module named 'pyparsing'` error inside `add-apt-repository`. ``` #19 [13/32] RUN add-apt-repository ppa:deadsnakes/ppa #19 0.509 Traceback (most recent call last): #19 0.509 File "/usr/lib/python3/dist-packages/launchpadlib/launchpad.py", line 34, in <module> #19 0.509 from httplib2 import proxy_info_from_environment #19 0.509 File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 52, in <module> #19 0.509 from . import auth #19 0.509 File "/usr/lib/python3/dist-packages/httplib2/auth.py", line 4, in <module> #19 0.509 import pyparsing as pp #19 0.509 ModuleNotFoundError: No module named 'pyparsing' ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55956 from dongjoon-hyun/SPARK-56889-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit c00f9a8) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x. |
Member
Author
|
Oh, unfortunately, it seems to fail still after installing Let me merge @zhengruifeng 's PR. |
zhengruifeng
pushed a commit
that referenced
this pull request
May 19, 2026
…ng from dockerfile ### What changes were proposed in this pull request? Remove `python3-pyparsing` from `dev/infra/Dockerfile`. ### Why are the changes needed? This line was added in #55956 as an attempt to fix the image build issue caused by removing 3.10. This was not the correct fix. The reason CI failed was because we somehow uninstalled `pyparsing` from system python3. We mitigated the issue later in #55946 . We should not keep this line around - it could confuse people in the future. This specific dockerfile is only used by 3.5. We should just retire the file after 3.5 EOL. We don't have to upgrade the 3.10 part (we didn't touch the 3.9 part of the file). We can just keep it as it is and delete it in the future. As we are using the docker file for 3.5, we probably shouldn't remove 3.10 because it's actually supported in 3.5. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI should work. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55965 from gaogaotiantian/remove-pyparsing. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
zhengruifeng
pushed a commit
that referenced
this pull request
May 19, 2026
…ng from dockerfile ### What changes were proposed in this pull request? Remove `python3-pyparsing` from `dev/infra/Dockerfile`. ### Why are the changes needed? This line was added in #55956 as an attempt to fix the image build issue caused by removing 3.10. This was not the correct fix. The reason CI failed was because we somehow uninstalled `pyparsing` from system python3. We mitigated the issue later in #55946 . We should not keep this line around - it could confuse people in the future. This specific dockerfile is only used by 3.5. We should just retire the file after 3.5 EOL. We don't have to upgrade the 3.10 part (we didn't touch the 3.9 part of the file). We can just keep it as it is and delete it in the future. As we are using the docker file for 3.5, we probably shouldn't remove 3.10 because it's actually supported in 3.5. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI should work. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55965 from gaogaotiantian/remove-pyparsing. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit eeecea4) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to install
python3-pyparsingbefore invokingadd-apt-repository.Why are the changes needed?
To avoid
ModuleNotFoundError: No module named 'pyparsing'error insideadd-apt-repository.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.