Skip to content

[SPARK-56889][INFRA][FOLLOWUP] Remove the unnecessary python3-pyparsing from dockerfile#55965

Closed
gaogaotiantian wants to merge 1 commit into
apache:masterfrom
gaogaotiantian:remove-pyparsing
Closed

[SPARK-56889][INFRA][FOLLOWUP] Remove the unnecessary python3-pyparsing from dockerfile#55965
gaogaotiantian wants to merge 1 commit into
apache:masterfrom
gaogaotiantian:remove-pyparsing

Conversation

@gaogaotiantian
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Remove python3-pyparsing from dev/infra/Dockerfile.

Why are the changes needed?

This line was added in #55956 as an attempt to fix the image build issue caused by removing 3.10.

This was not the correct fix. The reason CI failed was because we somehow uninstalled pyparsing from system python3. We mitigated the issue later in #55946 . We should not keep this line around - it could confuse people in the future.

This specific dockerfile is only used by 3.5. We should just retire the file after 3.5 EOL. We don't have to upgrade the 3.10 part (we didn't touch the 3.9 part of the file). We can just keep it as it is and delete it in the future. As we are using the docker file for 3.5, we probably shouldn't remove 3.10 because it's actually supported in 3.5.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI should work.

Was this patch authored or co-authored using generative AI tooling?

No.

@zhengruifeng
Copy link
Copy Markdown
Contributor

This specific dockerfile is only used by 3.5. We should just retire the file after 3.5 EOL.

This image is only for 3.5, but it is still kept in master because of the complicated CI dependencies.
I had some discussion with @LuciferYang before, probably we should split the workflow files by branch in the future, that is, branch-3.5 CI should only depend on the workflow files in branch 3.5

@gaogaotiantian
Copy link
Copy Markdown
Contributor Author

Yes - that's definitely the direction to go. We should not be able to change master and impact branch-3.5. That's the ideal world. We should be able to separate dependencies naturally with different branches, instead of logically doing it in our single super large shared file. We have a long way to go for our CI. However, removing this line should be a no brainer.

zhengruifeng pushed a commit that referenced this pull request May 19, 2026
…ng from dockerfile

### What changes were proposed in this pull request?

Remove `python3-pyparsing` from `dev/infra/Dockerfile`.

### Why are the changes needed?

This line was added in #55956 as an attempt to fix the image build issue caused by removing 3.10.

This was not the correct fix. The reason CI failed was because we somehow uninstalled `pyparsing` from system python3. We mitigated the issue later in #55946 . We should not keep this line around - it could confuse people in the future.

This specific dockerfile is only used by 3.5. We should just retire the file after 3.5 EOL. We don't have to upgrade the 3.10 part (we didn't touch the 3.9 part of the file). We can just keep it as it is and delete it in the future. As we are using the docker file for 3.5, we probably shouldn't remove 3.10 because it's actually supported in 3.5.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI should work.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #55965 from gaogaotiantian/remove-pyparsing.

Authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
(cherry picked from commit eeecea4)
Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
@zhengruifeng
Copy link
Copy Markdown
Contributor

merged to master/4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants