Skip to content

[SPARK-57949][PYTHON][TESTS] Use shortest temp base for direct-worker UDS path to fix macOS AF_UNIX path too long #57028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-57949][PYTHON][TESTS] Use shortest temp base for direct-worker UDS path to fix macOS AF_UNIX path too long #57028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...worker/core/src/test/scala/org/apache/spark/udf/worker/core/TestDirectWorkerHelpers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,20 @@ class TestDirectWorkerDispatcher(
private def shortTempBase(): Path = {
val candidates =
Seq("TMPDIR", "TEMP", "TMP").flatMap(sys.env.get).filter(_.nonEmpty) :+ "/tmp"
candidates
val usable = candidates
.map(Paths.get(_))
.find(p => Files.isDirectory(p) && Files.isWritable(p))
.filter(p => Files.isDirectory(p) && Files.isWritable(p))
// Pick the SHORTEST usable base, measured by its *real* (symlink-resolved) path,
// because that is what actually counts against the `sun_path` limit when the socket
// is bound. On macOS `$TMPDIR` is a long `/var/folders/<...>/T` path while `/tmp`
// resolves to the short `/private/tmp`; picking the first writable candidate (the old
// behavior) chose the long `$TMPDIR` and overflowed the 104-byte macOS limit
// ("AF_UNIX path too long"). Choosing the shortest real path avoids that.
def realLen(p: Path): Int =
try p.toRealPath().toString.length catch { case _: IOException => p.toString.length }
usable
.sortBy(realLen)
.headOption
.getOrElse(Paths.get(System.getProperty("java.io.tmpdir")))
}
}