Skip to content

[SPARK-57756][SQL][TESTS] Add buildSQLFunctionConf ANSI-invariant tests #57042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-lunin-db wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SPARK-57756][SQL][TESTS] Add buildSQLFunctionConf ANSI-invariant tests #57042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 65 additions & 2 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import org.scalatest.matchers.must.Matchers
import org.apache.spark.SparkException
import org.apache.spark.api.python.PythonEvalType
import org.apache.spark.sql.AnalysisException
import org.apache.spark.sql.catalyst.{AliasIdentifier, QueryPlanningTracker, TableIdentifier}
import org.apache.spark.sql.catalyst.catalog.{InMemoryCatalog, SessionCatalog}
import org.apache.spark.sql.catalyst.{AliasIdentifier, FunctionIdentifier, QueryPlanningTracker, TableIdentifier}
import org.apache.spark.sql.catalyst.catalog.{InMemoryCatalog, SessionCatalog, SQLFunction}
import org.apache.spark.sql.catalyst.dsl.expressions._
import org.apache.spark.sql.catalyst.dsl.plans._
import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
Expand Down Expand Up @@ -1894,6 +1894,69 @@ class AnalysisSuite extends AnalysisTest with Matchers {
val expectedPlan = Project(Seq(UnresolvedAttribute("i")), addColumnF).analyze
checkAnalysis(inputPlan, expectedPlan)
}

private def scalarSQLFunctionWithProps(
props: Map[String, String]): SQLFunction = {
val intType: DataType = IntegerType
val scalarReturnType: Either[DataType, StructType] = scala.Left(intType)
SQLFunction(
name = FunctionIdentifier("ansi_probe"),
inputParam = Some(new StructType().add("x", intType)),
returnType = scalarReturnType,
exprText = Some("x + 1"),
queryText = None,
comment = None,
collation = None,
deterministic = Some(true),
containsSQL = Some(true),
isTableFunc = false,
properties = props)
}

gridTest("SQL UDF body-resolution ANSI: persisted ANSI makes alwaysSetAnsiValue a no-op")(
Seq(false, true)) { applySessionOverrides =>
val ansiKey = SQLConf.ANSI_ENABLED.key
val fnWithPersistedAnsi = scalarSQLFunctionWithProps(Map(s"sqlConfig.$ansiKey" -> "false"))

withSQLConf(
SQLConf.ASSUME_ANSI_FALSE_IF_NOT_PERSISTED.key -> "true",
SQLConf.APPLY_SESSION_CONF_OVERRIDES_TO_FUNCTION_RESOLUTION.key ->
applySessionOverrides.toString,
ansiKey -> "true") {
val withFlag = Analyzer.buildSQLFunctionConf(
function = fnWithPersistedAnsi,
applySessionOverrides = applySessionOverrides,
alwaysSetAnsiValue = true)
val withoutFlag = Analyzer.buildSQLFunctionConf(
function = fnWithPersistedAnsi,
applySessionOverrides = applySessionOverrides,
alwaysSetAnsiValue = false)
assert(withFlag.settings.get(ansiKey) == "false")
assert(withoutFlag.settings.get(ansiKey) == "false")
assert(withFlag.settings.get(ansiKey) == withoutFlag.settings.get(ansiKey))
}
}

test("SQL UDF body-resolution ANSI: flag only bites when ANSI is unpersisted") {
val ansiKey = SQLConf.ANSI_ENABLED.key
val fnWithoutPersistedAnsi = scalarSQLFunctionWithProps(Map.empty)

withSQLConf(
SQLConf.ASSUME_ANSI_FALSE_IF_NOT_PERSISTED.key -> "true",
SQLConf.APPLY_SESSION_CONF_OVERRIDES_TO_FUNCTION_RESOLUTION.key -> "false",
ansiKey -> "true") {
val withFlag = Analyzer.buildSQLFunctionConf(
function = fnWithoutPersistedAnsi,
applySessionOverrides = false,
alwaysSetAnsiValue = true)
val withoutFlag = Analyzer.buildSQLFunctionConf(
function = fnWithoutPersistedAnsi,
applySessionOverrides = false,
alwaysSetAnsiValue = false)
assert(withFlag.settings.get(ansiKey) == "false")
assert(withoutFlag.settings.get(ansiKey) == null)
}
}
}

/**
Expand Down